ray-project / kuberay

A toolkit to run Ray applications on Kubernetes
Apache License 2.0
1.01k stars 341 forks source link

[Fix][Helm chart] Move service.headService -> head.headService in values.yaml #1998

Closed jjaniec closed 4 months ago

jjaniec commented 4 months ago

Why are these changes needed?

After spending a while not understanding why my monitoring annotations wouldn't be set on the head service of my clusters I noticed the chart uses .Values.head.headService instead of .Values.service.headService like specified in the default values.yaml

This PR would do the trick but I think using .Values.head.serviceType instead of .Values.service.type in the templates would be an even better solution for consistency :)

Checks

kevin85421 commented 4 months ago

I tested this PR manually.

Screen Shot 2024-03-14 at 6 37 22 PM