search

ray-project / kuberay

A toolkit to run Ray applications on Kubernetes
Apache License 2.0
1.01k stars 341 forks source link

ray-operator: parameterize Test_ShouldDeletePod #2000

Closed MadhavJivrajani closed 4 months ago

MadhavJivrajani commented 4 months ago

Why are these changes needed?

Parameterizing Test_ShouldDeletePod following the review comment here: https://github.com/ray-project/kuberay/pull/1386#pullrequestreview-1611687999

Also I'm assuming https://github.com/ray-project/kuberay/issues/1392 talks about Test_ShouldDeletePod and not Test_RunningPods_RayContainerTerminated? Lmk!

Related issue number

Fixes https://github.com/ray-project/kuberay/issues/1392

Checks

MadhavJivrajani commented 4 months ago

@kevin85421 / @architkulkarni could you PTAL whenever you get a chance, thanks!

MadhavJivrajani commented 4 months ago

Thanks for the comments @kevin85421! I've addressed them.