Closed rueian closed 3 months ago
Hi @kevin85421,
What do you think about the new AssociationOptions
that allows us to convert associations to either a slice of ListOption
or DeleteAllOfOption
?
I'd like to have your feedback, thanks!
What do you think about the new
AssociationOptions
that allows us to convert associations to either a slice ofListOption
orDeleteAllOfOption
?
LGTM
Hi @evalaiyc98, could you also help review this?
Sure!
I've noticed that the logic used here still resembles the original approach. I believe it would be beneficial to maintain consistency with the previous refactor part. What are your thoughts on this?
Why are these changes needed?
Introduce the following association functions to centralize many ad-hoc
MatchingLabels
that are scattered around:These functions return options of a new type
AssociationOptions
that can convert the options into either a[]client.ListOption
or a[]client.DeleteAllOfOption
so that we can use them like this:Checks