Clean up some global vars

ray-project / kuberay

A toolkit to run Ray applications on Kubernetes

Apache License 2.0

990 stars 330 forks source link

Clean up some global vars #2025

Open skonto opened 3 months ago

skonto commented 3 months ago

Why are these changes needed?

This moves some global variables to be local and allows to propagate any value via context for future use.

Related issue number

N/A

Checks

[X] I've made sure the tests are passing.
Testing Strategy
- [X] Unit tests
- [ ] Manual tests
- [ ] This PR is not tested :(

skonto commented 3 months ago

Hi @kevin85421! pinging for a review, was not sure who to ping tbh, I am new here.

kevin85421 commented 3 months ago

@skonto, thank you for the contribution! Would you mind rebasing with the master branch? I will do my best to review it this week, but I am currently busy with the release process, so I cannot guarantee a timeframe. Maybe @astefanutti @andrewsykim can review this PR if you have time. Thanks!

kevin85421 commented 3 months ago

cc @rueian would you mind reviewing this PR?

kevin85421 commented 3 months ago

@skonto @astefanutti any updates for this PR?