[Hotfix][CI] Pin setup-envtest dep - Githubissues

ray-project / kuberay

A toolkit to run Ray applications on Kubernetes

Apache License 2.0

990 stars 330 forks source link

[Hotfix][CI] Pin setup-envtest dep #2038

Closed kevin85421 closed 3 months ago

kevin85421 commented 3 months ago

Why are these changes needed?

Last week, setup-envtest upgraded the dependencies from Golang 1.20 to 1.22. The CI test fails with the following error message:

  go: sigs.k8s.io/controller-runtime/tools/setup-envtest@latest (in sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240323114127-e08b286e313e): go.mod:3: invalid go version '1.22.0': must match format 1.23

Related issue number

Checks

[ ] I've made sure the tests are passing.
Testing Strategy
- [ ] Unit tests
- [ ] Manual tests
- [ ] This PR is not tested :(

kevin85421 commented 3 months ago

will we need to unpin this?

Not sure. We have two options: (1) pin the tag of setup-envtest (2) upgrade Golang version from v1.20 to v1.22. However, (2) requires much more effort compared to (1). I will discuss with the community to check which one is the long term solution.