ray-project / kuberay

A toolkit to run Ray applications on Kubernetes
Apache License 2.0
990 stars 330 forks source link

[Refactor] Move MatchingLabels to association.go #2045

Open rueian opened 3 months ago

rueian commented 3 months ago

Following the PR https://github.com/ray-project/kuberay/pull/1948 and https://github.com/ray-project/kuberay/pull/2023,

We like to move all MatchingLabels to the association.go, so that we can maintain consistency in the association methods by not scattering MatchingLabels everywhere.

This issue is a todo list for tracking refactor progress and collaboration with other contributors.

@evalaiyc98 is already working on the suite_helpers_test.go part. cc @kevin85421

rueian commented 3 months ago

Appendix: Here is a MatchingLabels association diagram I previously figured out. Hope that can help someone who is interested in how CRD controllers associate each CR. associations