[Feature] Support ImagePullPolicy in Worker and Head NodeSpec

ray-project / kuberay

A toolkit to run Ray applications on Kubernetes

Apache License 2.0

990 stars 330 forks source link

[Feature] Support ImagePullPolicy in Worker and Head NodeSpec #2047

Closed revit13 closed 2 months ago

revit13 commented 3 months ago

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description

At present, it's not possible to configure the image pull policy for both the head and worker nodes. By default, the IfNotPresent policy is applied.

kevin85421 commented 3 months ago

cc @tedhtchang @z103cb @blublinsky

blublinsky commented 3 months ago

@kevin85421 once we complete current PR, we can look at other enhancements

ravishtiwari commented 2 months ago

Do we want to be able to specify the Image and Pull Policy at the head spec level here? Asking, since it is possible to specify pod template for Ray CR:

    template:
      spec:
        containers:
        # The Ray head container
        - name: ray-head
          image: rayproject/ray:2.9.0

so, we can specify the image pull policy, per container level.

However, if we want to be able to specify it here:

 headGroupSpec:

 workerGroupSpecs:

then, yes, we need these changes

blublinsky commented 2 months ago

Its a useful and simple change. Can we, please, merge https://github.com/ray-project/kuberay/pull/1728 and then its an easy implementation