search

ray-project / kuberay

A toolkit to run Ray applications on Kubernetes
Apache License 2.0
1.16k stars 373 forks source link

[Feature] Publish `python-client` to PyPI #2078

Open danielgafni opened 5 months ago

danielgafni commented 5 months ago

Search before asking

Description

Currently it's only possible to install it from git, which is not optimal. python-client should be on PyPI.

Also, the package would have to be renamed from python-client to kuberay-client or smth.

Use case

I am building a dagster-ray integration library.

I would like to depend on python-client, but depending on a git URI means I can't really apply version constraints. This can cause dependency related issues for downstream users.

Also, the current package name, python-client, is too general and doesn't point to KubeRay.

I am willing to work on all of these changes, as well as cleaning up the code (I've seen some duplicated methods, for example). Let me know if these changes are welcome.

Related issues

No response

Are you willing to submit a PR?

kevin85421 commented 5 months ago

I would like to depend on python-client, but depending on a git URI means I can't really apply version constraints. This can cause dependency related issues for downstream users.

I am not sure whether it is a good idea to depend on a Python client. The Python client is maintained by the community and not officially by the Ray community, and it seems that the community does not actively maintain it.

danielgafni commented 5 months ago

I ended up subclassing it and overriding a few methods to fix some issues.

Is anyone else interested in a stable and well-tested Python client? If so, I can look into publishing my code as a standalone package.