ray-project / kuberay

A toolkit to run Ray applications on Kubernetes
Apache License 2.0
982 stars 330 forks source link

[Refactor][RayJob] Use AssociationOptions and Delete isAllPodsRunning #2079

Closed evalaiyc98 closed 2 months ago

evalaiyc98 commented 2 months ago

Why are these changes needed?

This PR follows up on #2045. The objective of this PR is to uphold consistency in association methods and prevent the scattering of MatchingLabels usage throughout the entire codebase.

In this PR, I concentrate on modifying the files related to RayJob. This includes using the AssociationOptions function to replace the previous section and removing isAllPodsRunning function due to its lack of usage.

Related issue number

2045

Checks

evalaiyc98 commented 2 months ago

Hi @rueian , could you help review this PR? I want to know if there is anything that needs improvement.

rueian commented 2 months ago

Hi @evalaiyc98,

These changes look good to me!

evalaiyc98 commented 2 months ago

Close this PR because the issue has been resolved.