Init dashboardClientFunc and httpProxyClientFunc by the config arg

ray-project / kuberay

A toolkit to run Ray applications on Kubernetes

Apache License 2.0

982 stars 330 forks source link

Closed bugorz closed 1 month ago

bugorz commented 2 months ago

Based on @kevin85421's suggestion at https://github.com/ray-project/kuberay/pull/1980#discussion_r1550243563
Instead of passing function(s) to NewRayServiceReconciler and NewRayJobReconciler, initialing them by the v1alpha1.Configuration configuration

[x] I've made sure the tests are passing.
Testing Strategy
- [] Unit tests
- [x] Manual tests
- [ ] This PR is not tested :(

bugorz commented 2 months ago

cc @rueian @kevin85421

rueian commented 2 months ago

LGTM

rueian commented 2 months ago

@kevin85421, This is our friend Sean's first contribution to KubeRay. Please take a look when you are available.

hsiang-c commented 1 month ago

Thanks @kevin85421 for the guidance.