ray-project / kuberay

A toolkit to run Ray applications on Kubernetes
Apache License 2.0
982 stars 330 forks source link

[Refactor] Renaming RayHttpProxyClient attribute UseProxy #1980 #2093

Closed Xiao75896453 closed 2 months ago

Xiao75896453 commented 2 months ago

Why are these changes needed?

Renaming RayHttpProxyClient.UseProxy to RayHttpProxyClient.UseKubernetesProxy

Related issue number

#1980

Checks

Xiao75896453 commented 2 months ago

@rueian @kevin85421

rueian commented 2 months ago

@kevin85421, This is our newbie's first contribution. Please take a look when you are available.

Xiao75896453 commented 2 months ago

To @kevin85421 @rueian Regarding the following two issues. Could I deal with them in this PR as well?

kevin85421 commented 2 months ago

@Xiao75896453 It's better to include https://github.com/ray-project/kuberay/pull/1980#discussion_r1567647956 in this PR. https://github.com/ray-project/kuberay/pull/1980#discussion_r1550243563 is handled by #2092.

Xiao75896453 commented 2 months ago

@Xiao75896453 It's better to include #1980 (comment) in this PR. #1980 (comment) is handled by #2092.

To @kevin85421 Thanks! I have deal with it 🙏

kevin85421 commented 2 months ago

Would you mind rebasing with the master branch? Thanks!

Xiao75896453 commented 2 months ago

Would you mind rebasing with the master branch? Thanks!

To @kevin85421 I think rebase is no problem 👍 Who performs rebase, Kevin or myself?

kevin85421 commented 2 months ago

Who performs rebase, Kevin or myself?

In most cases, the PR author should resolve the conflicts.

Xiao75896453 commented 2 months ago

Who performs rebase, Kevin or myself?

In most cases, the PR author should resolve the conflicts.

To @kevin85421 OK, I have resolved the conflicts. Thanks Kevin.

kevin85421 commented 2 months ago

@Xiao75896453 Congratulations on your first PR!