Closed Xiao75896453 closed 2 months ago
@rueian @kevin85421
@kevin85421, This is our newbie's first contribution. Please take a look when you are available.
To @kevin85421 @rueian Regarding the following two issues. Could I deal with them in this PR as well?
@Xiao75896453 It's better to include https://github.com/ray-project/kuberay/pull/1980#discussion_r1567647956 in this PR. https://github.com/ray-project/kuberay/pull/1980#discussion_r1550243563 is handled by #2092.
@Xiao75896453 It's better to include #1980 (comment) in this PR. #1980 (comment) is handled by #2092.
To @kevin85421 Thanks! I have deal with it 🙏
Would you mind rebasing with the master branch? Thanks!
Would you mind rebasing with the master branch? Thanks!
To @kevin85421 I think rebase is no problem 👍 Who performs rebase, Kevin or myself?
Who performs rebase, Kevin or myself?
In most cases, the PR author should resolve the conflicts.
Who performs rebase, Kevin or myself?
In most cases, the PR author should resolve the conflicts.
To @kevin85421 OK, I have resolved the conflicts. Thanks Kevin.
@Xiao75896453 Congratulations on your first PR!
Why are these changes needed?
Renaming
RayHttpProxyClient.UseProxy
toRayHttpProxyClient.UseKubernetesProxy
Related issue number
#1980
Checks