[Chore] Fix golangci-lint rule: gosec - Githubissues

ray-project / kuberay

A toolkit to run Ray applications on Kubernetes

Apache License 2.0

963 stars 328 forks source link

[Chore] Fix golangci-lint rule: gosec #2163

Closed MortalHappiness closed 2 weeks ago

MortalHappiness commented 1 month ago

Why are these changes needed?

Based on https://github.com/ray-project/kuberay/pull/2128, there are some rules that need manual fixing. This PR fixes the rule: gosec

See https://golangci-lint.run/usage/linters/ for details.

This PR does the following:

Adds a comment to explain why we can use Sha1 hash.
Adds a comment to explain InsecureSkipVerify is used.

Related issue number

N/A

Checks

[x] I've made sure the tests are passing.
Testing Strategy
- [ ] Unit tests
- [x] Manual tests
- [ ] This PR is not tested :(