ray-project / kuberay

A toolkit to run Ray applications on Kubernetes
Apache License 2.0
963 stars 328 forks source link

Use login shell for Submitter Pod command #2209

Open mickvangelderen opened 2 days ago

mickvangelderen commented 2 days ago

Search before asking

Description

The head and worker pods use a login shell bash -l but the submitter pod command does not.

The documentated preStop lifecycle should probably also use a login shell and bash instead of sh for consistency.

Use case

I'm using pixi inside of Docker and activating the environment requires running pixi's shell hook. I added source shell-hook.sh to .bash_profile so that this happens for login shells.

What I actually would prefer is if ray could use args everywhere, rather than command so that the ENTRYPOINT stays intact.

Related issues

No response

Are you willing to submit a PR?