search

ray-project / kuberay

A toolkit to run Ray applications on Kubernetes
Apache License 2.0
1.3k stars 418 forks source link

[Feature] Disable zero downtime upgrade for a RayService #2397

Open smit-kiri opened 2 months ago

smit-kiri commented 2 months ago

Search before asking

Description

Currently we have a global flag to disable zero downtime upgrades for ALL RayService resources. It would be great to have a flag in the CRD to disable zero-downtime upgrade for a specific RayService resource.

Use case

We're managing multiple RayService resources, and want to disable zero-downtime upgrade in one of the resources.

Related issues

No response

Are you willing to submit a PR?

andrewsykim commented 2 months ago

I would be in favor of a new field in RayService to toggle the upgrade policy. We can default it to zero-downtime upgrade for compatibility. What do you think @kevin85421

andrewsykim commented 2 months ago

There are some other proposals floating around for supporting N RayCluster per RayService as well, it might be good to revisit this as part of those proposals.

smit-kiri commented 2 months ago

There are some other proposals floating around for supporting N RayCluster per RayService as well, it might be good to revisit this as part of those proposals.

I would also be in favor of having N RayCluster per RayService!