[Feature] Add a feature gate for `submissionMode: UserMode` for v1.3.0

ray-project / kuberay

A toolkit to run Ray applications on Kubernetes

Apache License 2.0

1.21k stars 392 forks source link

[Feature] Add a feature gate for `submissionMode: UserMode` for v1.3.0 #2418

Open kevin85421 opened 3 weeks ago

kevin85421 commented 3 weeks ago

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description

KubeRay v1.2.2 is a special release that is exclusive to Ray Summit. We don't have enough time to follow our API conventions. For v1.3.0, we should add a feature gate for submissionMode.

Use case

No response

Related issues

No response

Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

andrewsykim commented 2 weeks ago

@kevin85421 since the new API is available v1.2.2 it probably doesn't make sense to add a feature gate for v1.3, unless we re-release v1.2.2. I'm okay to close this one, what do you tihnk?

kevin85421 commented 2 weeks ago

I think either adding or not adding a feature gate is fine with me. UserMode should only be used by the Kubectl plugin, which is in alpha status, meaning we can still update the API.