[Dashboard] Confusing `workers` terminology

ray-project / ray

Ray is an AI compute engine. Ray consists of a core distributed runtime and a set of AI Libraries for accelerating ML workloads.

https://ray.io

Apache License 2.0

34k stars 5.78k forks source link

[Dashboard] Confusing `workers` terminology #24277

Open Yard1 opened 2 years ago

Yard1 commented 2 years ago

Description

In Ray Cluster Configuration, "worker" refers to worker nodes. However, in Dashboard, "worker" refers to Ray processes on nodes (which are also confusingly named "hosts"). This is inconsistent and confusing, especially for new users. As an example, a user was setting maxWorkers: 0 parameter in Ray Cluster Configuration file, thinking it will mean that no Ray Processes will be scheduled on nodes of this type, not realising it refers to something completely else.

Use case

No response

Yard1 commented 2 years ago

cc @scottsun94 @Wendi-anyscale

scottsun94 commented 2 years ago

@wuisawesome told me that

we don't have any plan to improve the ray cluster config/yaml file
Another confusing thing is the head_node_type. Its value is available_node_types

@Yard1 How do we triage those issues?

stale[bot] commented 2 years ago

Hi, I'm a bot from the Ray team :)

To help human contributors to focus on more relevant issues, I will automatically add the stale label to issues that have had no activity for more than 4 months.

If there is no further activity in the 14 days, the issue will be closed!

If you'd like to keep the issue open, just leave any comment, and the stale label will be removed!
If you'd like to get more attention to the issue, please tag one of Ray's contributors.

You can always ask for help on our discussion forum or Ray's public slack channel.

stale[bot] commented 2 years ago

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

scottsun94 commented 2 years ago

Not resolved. Keep it open

stale[bot] commented 2 years ago

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

sijieamoy commented 1 year ago

@scottsun94 has this issue been addressed in the new dashboard?

scottsun94 commented 1 year ago

Not yet. "Worker" is still used in some legacy UI without explanation. Ideally, in 2.4, we'll just use "worker process" or add tooltips for explanation.

stale[bot] commented 1 year ago

Hi, I'm a bot from the Ray team :)

To help human contributors to focus on more relevant issues, I will automatically add the stale label to issues that have had no activity for more than 4 months.

If there is no further activity in the 14 days, the issue will be closed!

If you'd like to keep the issue open, just leave any comment, and the stale label will be removed!
If you'd like to get more attention to the issue, please tag one of Ray's contributors.

You can always ask for help on our discussion forum or Ray's public slack channel.

sijieamoy commented 1 year ago

@scottsun94 checking in to see if we can close this ticket now?

scottsun94 commented 1 year ago

On the cluster configuration side: https://github.com/ray-project/ray/issues/36076. We'll not use "worker" alone to refer to "worker node" any more.

On dashboard, no work has been done yet. Keep tracking it.

stale[bot] commented 1 year ago

Hi, I'm a bot from the Ray team :)

To help human contributors to focus on more relevant issues, I will automatically add the stale label to issues that have had no activity for more than 4 months.

If there is no further activity in the 14 days, the issue will be closed!

If you'd like to keep the issue open, just leave any comment, and the stale label will be removed!
If you'd like to get more attention to the issue, please tag one of Ray's contributors.

You can always ask for help on our discussion forum or Ray's public slack channel.