search

ray-project / ray

Ray is an AI compute engine. Ray consists of a core distributed runtime and a set of AI Libraries for accelerating ML workloads.
https://ray.io
Apache License 2.0
33.75k stars 5.74k forks source link

[Core][Metrics] Prometheus-client not working with the latest version. #25523

Open rkooo567 opened 2 years ago

rkooo567 commented 2 years ago

What happened + What you expected to happen

When the latest Prometheus-client is used, the following error seems to occur based on the report. 

  File "/home/ray/anaconda3/lib/python3.7/socket.py", line 752, in getaddrinfo
    for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -2] Name or service not known

Although we restrict the Prometheus client version in the master, it is ideal to fix this since it seems to be pretty common to download wrong dependencies (it's quite common in python). Or we should at least raise a better error message.

Versions / Dependencies

Master

Reproduction script

Run the lastest prometheus client

Issue Severity

Low: It annoys or frustrates me.

rkooo567 commented 2 years ago

@alanwguo said it is fixed. @rkooo567 to verify and close.

galenhwang commented 2 years ago

I believe the fix was https://github.com/ray-project/ray/pull/23766?

rkooo567 commented 2 years ago

I don't think that fixes the root cause. It just mitigates the issue. It's ideal we don't restrict the version requirement.