Open simonsays1980 opened 1 year ago
Thanks a lot for reporting this :)
@simonsays1980 Running the reproduction script does not result in an error on my side. Can you have a look again?
@simonsays1980 Running the reproduction script does not result in an error on my side. Can you have a look again?
I can reproduce it again after installing a fresh vitual environment:
pyenv local 3.9.12
python -m venv .venv-2-5-1
source .venv-2-5-1/bin/activate
python -m pip install --upgrade pip
python -m pip install tensorflow tensorflow_probability
python -m pip install "ray[default,tune,rllib]"
Ar you already running inside of the nightly-built
? It might have been modified there already?
That's what I'm thinking, too. I have not run this with 2.5.1, since the linked PR is targeted at master. On master, it appears to be fine.
That's what I'm thinking, too. I have not run this with 2.5.1, since the linked PR is targeted at master. On master, it appears to be fine.
If this is fine on master there is nothing more to do. I will close this issue and the corresponding PR.
Thanks!
Sorry, I have to reopen. I do not see it fixed on master. WIth the last nightly it still gives me the error. I can write a PR.
I have the same error and passing framework to _validate (as done in the PR by @simonsays1980) fixes the issue!
What happened + What you expected to happen
What happened
I ran
PPO
withRLModule
and_enable_learner_api=True
usingframework="tf2"
.The following error occurred:
What I expected to happen
That using TensorFlow2 runs with RLModule.
Versions / Dependencies
Fedora 37 Python 3.9.12 Ray 2.5.1
Reproduction script
Issue Severity
Medium: It is a significant difficulty but I can work around it.