Open vincent-pli opened 3 months ago
At first, I guess I should not start vllm engine in reconfigure
function, I'm not dig in to the inner logic of ray deployment, maybe at the phase reconfigure
was calling the pg
or bundles
has not ready.
but after some experimental, I found as long as reconfigure
existed, even I do nothing in that function, the placement_group_bundles
predefined was not works
any comment?
I guess the issue is cased by incompatible between pydantic 1.x and 2.x I know ray adopted 1.x but I have to adopt 2.x since vllm addressed 2.x
lol!
but why the pydantic version incompatible could infect bind()
or reconfigure
is still unknown, I guess we need describe it at least in document.
What happened + What you expected to happen
Follow the guide here:https://github.com/ray-project/ray/blob/c4a87ee474041ab7286a41378f3f6db904e0e3c5/doc/source/serve/doc_code/vllm_openai_example.py#L117
but I found if the deployment has function:
reconfigure
, theplacement_group_bundles
will not take effect, when I removereconfigure
everything worksVersions / Dependencies
v2.20.0 Python 3.10.12 ubuntu 22.04
Reproduction script
if
VLLMDeployment
hasreconfigure
function, theplacement_group_bundles
will not been respected.Issue Severity
High: It blocks me from completing my task.