ray-project / ray

Ray is an AI compute engine. Ray consists of a core distributed runtime and a set of AI Libraries for accelerating ML workloads.
https://ray.io
Apache License 2.0
34.2k stars 5.81k forks source link

BUILD: patch zlib for macos and protobuf for windows #48794

Open mattip opened 1 week ago

mattip commented 1 week ago

What happened + What you expected to happen

Over at conda-forge I needed to patch the grpc, boost, and prometheus-cpp build recipes to remove fdopen from zlib, which fails to compile when conda-forge updated to the azure macOS-13 image. The change is part of zlib-1.3.1.

I also needed to patch protobuf for newer windows SDK which no longer has a constant NAN, here is the upstream fix.

I think the best way forward would be to update the dependencies, but that might have unintended consequences. I could submit the patches I developed for the conda-forge build here, would that be welcome?

Versions / Dependencies

ray-2.39.0 built on Azure CI via conda-forge

Reproduction script

bazel --verbose_failures --local_cpu_resources=4 -- //:ray_pkg

Issue Severity

Medium: It is a significant difficulty but I can work around it.

jjyao commented 1 week ago

Let's try to upgrade, if it's hard we can patch.

mattip commented 1 week ago

It may not be easy to upgrade.

jjyao commented 1 week ago

Let's patch then to unblock the conda release.