search

ray-project / ray_beam_runner

Ray-based Apache Beam runner
Apache License 2.0
42 stars 12 forks source link

Rename immutable context managers to *Context #28

Open pabloem opened 2 years ago

pabloem commented 2 years ago

Specifuically RunnerContextManager and BundleContextManager are what we need to improve.

pabloem commented 2 years ago

Also, make RunnerContextManager fully immutable (will also help to persist it with ray.put) to avoid the cost of passing it around ever and over.

wilsonwang371 commented 1 year ago

let me c if i can start looking into this issue. @pabloem can you later give some help here if I take this item?

pabloem commented 1 year ago

I think it's fine if @flyingImer picks this up ? : )

flyingImer commented 1 year ago

@pabloem not sure I follow the RunnerContextManager one - not seeing any reference in the code base, am I missing anything here?

Do you mean RayRunnerExecutionContext and RayBundleContextManager ?