search

ray-project / ray_beam_runner

Ray-based Apache Beam runner
Apache License 2.0
41 stars 12 forks source link

"Store Benchmark Results" task is broken #46

Closed pabloem closed 1 year ago

pabloem commented 1 year ago

Something about storing the outcome for benchmarks is causing failures in the task.

https://github.com/ray-project/ray_beam_runner/actions/runs/3239121252/jobs/5308126444

Any idea of what's going on @wilsonwang371 ?

wilsonwang371 commented 1 year ago

it looks like a permission issue. does it have anything to do with branch?

wilsonwang371 commented 1 year ago

I posted a patch #48

iasoon commented 1 year ago

Closed by #48

iasoon commented 1 year ago

On a second note, this is not fixed - we are not saving the benchmarks results currently. I think the workflow is failing because it's running from a PR, for which the GITHUB_TOKEN has read-only access by default (and I guess we want this, otherwise a PR would overwrite the results from master).

I have opened #50 to change this.