search

ray-project / ray_beam_runner

Ray-based Apache Beam runner
Apache License 2.0
42 stars 12 forks source link

Update benchmark with real tests #51

Closed wilsonwang371 closed 1 year ago

wilsonwang371 commented 2 years ago

@pabloem hi pablo, is it normal to have the benchmark test running for almost 30 minutes? The test is the one you mentioned in https://github.com/ray-project/ray_beam_runner/issues/21

image

wilsonwang371 commented 2 years ago

cc @iasoon @pdames

pabloem commented 2 years ago

that does not sound normal, but maybe it is given our current implementation? if it's running to completion then it should be fine?

wilsonwang371 commented 2 years ago

that does not sound normal, but maybe it is given our current implementation? if it's running to completion then it should be fine?

let me check if i can have more log printed and see what has happened.

pabloem commented 1 year ago

this looks good to me. Thanks!

@jjyao - I think we can set up a github pages website for this repository so that we can see the benchmark results. WDYT?

wilsonwang371 commented 1 year ago

@pabloem Hi Pablo, please take a look at the new patch. Thanks

pabloem commented 1 year ago

lgtm!