ray-project / ray_lightning

Pytorch Lightning Distributed Accelerators using Ray
Apache License 2.0
211 stars 34 forks source link

Pop kwargs to support `LightningCLI` #154

Closed amogkam closed 2 years ago

amogkam commented 2 years ago

Closes #151.

As discussed in #151, LightningCLI does not support kwargs well, and assume kwargs are all passed into the superclass even though that's not necessarily the case. We do a small workaround here to pop certain values from kwargs to unblock using RayPlugin with LightningCLI until the actual issue is fixed upstream in PTL.