search

ray-project / rayfed

A multiple parties joint, distributed execution engine based on Ray, to help build your own federated learning frameworks in minutes.
https://rayfed.readthedocs.io
Apache License 2.0
91 stars 20 forks source link

Reset sending queue after `fed.shutdown` #125

Closed NKcqx closed 1 year ago

NKcqx commented 1 year ago

The send queue won't be cleared when shutting down rayfed, the message left in the queue may be read in the next session, i.e. the next time calling fed.init , which is one of the reason what happened in this issue

Note that this PR couldn't completely fix that problem because there're also flying request after fed.shutdown, will open another PR.

NKcqx commented 1 year ago

2 comments:

  1. Add a unit test.
  2. PR title should be updated to get more detailed, like "Fix repeated sessions bug." or some thing related to what you concretely do.

Thx for the suggestions ～!

jovany-wang commented 1 year ago

Please address the conflicts before merging~