Validate address and cluster info.

ray-project / rayfed

A multiple parties joint, distributed execution engine based on Ray, to help build your own federated learning frameworks in minutes.

https://rayfed.readthedocs.io

Apache License 2.0

91 stars 20 forks source link

Closed jovany-wang closed 1 year ago

jovany-wang commented 1 year ago

This PR is used to validate the address passed into fed.init(), leading it following one of the rules:

local for starting a new cluster, or localhost for connecting a local cluster.
'ip:port' format, where the IP needs to follow the IP address specifications and the port is a number.
'hostname:port' format, where the hostname is a string and the port is a number.
An HTTPS or HTTP link starting with 'https://' or 'http://'.

zhouaihui commented 1 year ago

LGTM. The validation of RecvProxy address will be next pr?

jovany-wang commented 1 year ago

LGTM. The validation of RecvProxy address will be next pr?

@zhouaihui I missed that. Just committed it right now.