search

ray-project / rayfed

A multiple parties joint, distributed execution engine based on Ray, to help build your own federated learning frameworks in minutes.
https://rayfed.readthedocs.io
Apache License 2.0
91 stars 20 forks source link

feat: Do not init ray during fed init. (#128) #129

Closed fengsp closed 1 year ago

fengsp commented 1 year ago

This closes #128

fengsp commented 1 year ago

This is a breaking change, it is hard to not break user code, considering the following:

Maybe we do not need to worry about the breaking change yet? Any thoughts?

jovany-wang commented 1 year ago

@zhouaihui Please review this breaking change API. I'm not sure if it breaks secretflow usage.

zhouaihui commented 1 year ago

Yes, this PR will affect SecretFlow but minor code modification is acceptable.

jovany-wang commented 1 year ago

@fengsp Secretflow is using rayfed, so i believe this PR should be approved by @zhouaihui .

jovany-wang commented 1 year ago

This could be merged once it gets approved by both @zhouaihui and @NKcqx

jovany-wang commented 1 year ago

Yes, this PR will affect SecretFlow but minor code modification is acceptable.

Thanks. so could you approve this PR?