search

ray-project / rayfed

A multiple parties joint, distributed execution engine based on Ray, to help build your own federated learning frameworks in minutes.
https://rayfed.readthedocs.io
Apache License 2.0
91 stars 20 forks source link

Setup ProxyActor Config [1/N] #132

Closed NKcqx closed 1 year ago

NKcqx commented 1 year ago

This is the first step of #134

This PR provides cross_silo_send_resource_label and cross_silo_recv_resource_label config in fed.init and convert them to the "resources" field of ActorClass.options.

NKcqx commented 1 year ago

This PR remove the original cross_silo_send_max_retries argument in fed.init, because it has become the field "max_task_retries" of cross_silo_xx_options, which is what cross_silo_send_max_retries stands for under the hood, keeping it will cause conflicts.

zhouaihui commented 1 year ago

+1. Expose some common options is more maintainable and extensible instead of the options of ray.Actor. SendProxy could be ray.actor or something else.

NKcqx commented 1 year ago

Make sense, I'll use a class to only expose certain options

jovany-wang commented 1 year ago

This PR remove the original cross_silo_send_max_retries argument in fed.init, because it has become the field "max_task_retries" of cross_silo_xx_options, which is what cross_silo_send_max_retries stands for under the hood, keeping it will cause conflicts.

Move this to PR description?

NKcqx commented 1 year ago

As discussed offline, this PR LGTM.

And you may need file an issue to trace the related coming items.

Sure