Reorg config. - Githubissues

ray-project / rayfed

A multiple parties joint, distributed execution engine based on Ray, to help build your own federated learning frameworks in minutes.

https://rayfed.readthedocs.io

Apache License 2.0

87 stars 20 forks source link

Reorg config. #164

Closed jovany-wang closed 1 year ago

jovany-wang commented 1 year ago

[x] deprecated specifying config per party and also remove the related unit test.
[x] made all face config API as dict type instead of an internal strong type.
[x] simplified param address.

jovany-wang commented 1 year ago

@NKcqx Then how can we make listening addresses work?

NKcqx commented 1 year ago

@NKcqx Then how can we make listening addresses work?

Since listen_addr is used inside ReceiveProxy, i.e. cross-silo communication, and it's kinda like an advanced config, what do you think we move it to CrossSiloMessageConfig?

jovany-wang commented 1 year ago

Since listen_addr is used inside ReceiveProxy, i.e. cross-silo communication, and it's kinda like an advanced config, what do you think we move it to CrossSiloMessageConfig?

I don't have idea yet. Let's move forward as what you described here.

jovany-wang commented 1 year ago

@fengsp @NKcqx Let us move listening addresses into cross silo config as a workaround right now.

fengsp commented 1 year ago

@fengsp @NKcqx Let us move listening addresses into cross silo config as a workaround right now.

I believe this is right, since we do not need to config listen_addr for other parties at all

jovany-wang commented 1 year ago

@NKcqx @fengsp @zhouaihui Please help another review.