ray-project / rayfed

A multiple parties joint, distributed execution engine based on Ray, to help build your own federated learning frameworks in minutes.
https://rayfed.readthedocs.io
Apache License 2.0
87 stars 20 forks source link

feat: add ReceiverSenderProxy. #168

Closed zhouaihui closed 11 months ago

zhouaihui commented 12 months ago
zhouaihui commented 12 months ago

I do not get this, why are we adding a ReceiverSendProxy

Since some communication backends are bidirectional, meaning that the proxy can do sending/receiving, e.g. SecretFlow Link, grpc streaming. Now we need to apply SecretFlow link to RayFed. That's why we need this PR, though it's not graceful .

do we have to keep both of them.

Yea, the default is separated actors still. RayFed does not provide ReceiverSendProxy implementation.

zhouaihui commented 11 months ago

Some ut is flaky, i will open a new PR to fix https://github.com/ray-project/rayfed/issues/153#issuecomment-1664875763