Closed zhouaihui closed 10 months ago
fed.shutdown(forced=False)
or
fed.force_shutdown()
?
We can hide the forced behavior? Once bob received error from alice, the job became meaningless already. So bob can mark the job as failure when received an error from alice, and then do not wait for data sending when shutdown.
Receiving an error from peer
and Error on self data sending
are same case actually. We should not wait data sending if error occurred no matter from alice itself or from bob, since a job became meaningless already.
Receiving an error from peer and Error on self data sending are same case actually. We should not wait data sending if error occurred no matter from alice itself or from bob, since a job became meaningless already.
+1
What happened
Demo code.
A possible solution
Give an forced option to
fed.shutdown(forced=False)
, ifforced==True
, shutdown anyway ignoring the data sending.