ray-project / rayfed

A multiple parties joint, distributed execution engine based on Ray, to help build your own federated learning frameworks in minutes.
https://rayfed.readthedocs.io
Apache License 2.0
92 stars 21 forks source link

[bug] cross_silo_grpc_retry_policy doesn't work. #67

Closed zhaocaibei123 closed 1 year ago

zhaocaibei123 commented 1 year ago

It seems that the argument maxAttempts: 360 is not able to be set correctly. Please see the following error, it shows that the value is 5 instead of 360(I set it to 360). 644fb478915f14696b86ef4409cb61f8

reproduced script: image

jovany-wang commented 1 year ago

@zhouaihui CC Also we should change the the context in English due to this is a global community ~

jovany-wang commented 1 year ago

@zhaocaibei123 Could you give the reproduced script?

jovany-wang commented 1 year ago

Hi @zhaocaibei123 ,

  1. According to the grpc doc, maxAttempts will be clamped to 5 if it > 5. So I don't think it's a RayFed bug.

  2. I know your pain point, maybe we could take the action on https://github.com/ray-project/rayfed/issues/66