Closed richardliaw closed 3 years ago
@richardliaw Does it mean we should get rid of the automatic conversion from dict
to algo specific search space, and instead convert dict
s to tune's unified search space and then pass it to the algos? Leaving already converted search spaces as-is, of course.
Hmm, possible to leave that as-is. The issue is so that users can pass in their search space in the Tune API format.
Adding just that should be a quick and easy change. Just to be certain - we don't need to do any processing of it here, do we? I took a look at Tune code and it seems like it's all handled within the algos themselves.
yep! all is done in tune
On Thu, Oct 29, 2020 at 3:14 PM Antoni Baum notifications@github.com wrote:
Adding just that should be a quick and easy change. Just to be certain - we don't need to do any processing of it here, do we? I took a look at Tune code and it seems like it's all handled within the algos themselves.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ray-project/tune-sklearn/issues/124#issuecomment-719054479, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCRZZOM7WZ6Q2JOA6BAQDDSNHSMVANCNFSM4TEE7BPA .
Happy to work on this, then.
Great! I'll assign this to you, and just cc @krfricke when you're done!
Awesome! This should be addressed with the new release :)
Tune now has a unified search space on 1.0; tune-sklearn should support that space too.