ray-project / tune-sklearn

A drop-in replacement for Scikit-Learn’s GridSearchCV / RandomizedSearchCV -- but with cutting edge hyperparameter tuning techniques.
https://docs.ray.io/en/master/tune/api_docs/sklearn.html
Apache License 2.0
465 stars 52 forks source link

Feature Request: Support unified search space #124

Closed richardliaw closed 3 years ago

richardliaw commented 3 years ago

Tune now has a unified search space on 1.0; tune-sklearn should support that space too.

Yard1 commented 3 years ago

@richardliaw Does it mean we should get rid of the automatic conversion from dict to algo specific search space, and instead convert dicts to tune's unified search space and then pass it to the algos? Leaving already converted search spaces as-is, of course.

richardliaw commented 3 years ago

Hmm, possible to leave that as-is. The issue is so that users can pass in their search space in the Tune API format.

Yard1 commented 3 years ago

Adding just that should be a quick and easy change. Just to be certain - we don't need to do any processing of it here, do we? I took a look at Tune code and it seems like it's all handled within the algos themselves.

richardliaw commented 3 years ago

yep! all is done in tune

On Thu, Oct 29, 2020 at 3:14 PM Antoni Baum notifications@github.com wrote:

Adding just that should be a quick and easy change. Just to be certain - we don't need to do any processing of it here, do we? I took a look at Tune code and it seems like it's all handled within the algos themselves.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ray-project/tune-sklearn/issues/124#issuecomment-719054479, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCRZZOM7WZ6Q2JOA6BAQDDSNHSMVANCNFSM4TEE7BPA .

Yard1 commented 3 years ago

Happy to work on this, then.

richardliaw commented 3 years ago

Great! I'll assign this to you, and just cc @krfricke when you're done!

richardliaw commented 3 years ago

Awesome! This should be addressed with the new release :)