search

ray-project / tune-sklearn

A drop-in replacement for Scikit-Learn’s GridSearchCV / RandomizedSearchCV -- but with cutting edge hyperparameter tuning techniques.
https://docs.ray.io/en/master/tune/api_docs/sklearn.html
Apache License 2.0
465 stars 52 forks source link

Change BaseEstimator to BaseSearchCV #192

Closed timvink closed 3 years ago

timvink commented 3 years ago

Adresses https://github.com/ray-project/ray/issues/14534.

Yard1 commented 3 years ago

LGTM

timvink commented 3 years ago

Travis CI fails on linux with an optuna error

E AttributeError: 'Study' object has no attribute 'ask'

And on mac on ray with:

E ray.exceptions.RayActorError: The actor died unexpectedly before finishing this task. Check python-core-worker-*.log files for more information.

I checked travis, and it these exact two errors also occured previously on the master branch (https://travis-ci.com/github/ray-project/tune-sklearn/builds/219073636).

So it seems the build was already failing before this PR.

Yard1 commented 3 years ago

All that matters is that github actions pass, Travis is a bit outdated

Yard1 commented 3 years ago

Cc @richardliaw

timvink commented 3 years ago

Any plans on an upcoming patch release ? ;)

richardliaw commented 3 years ago

Sure! Let me put it on my sprint.

richardliaw commented 3 years ago

Sorry for the delay! @timvink release is done :)