search

ray-project / tutorial

778 stars 212 forks source link

Update tutorials to fix hyperparameters and function name change #135

Closed anthonyhsyu closed 5 years ago

richardliaw commented 5 years ago

Looks good; can merge if you just reduce the first example from 10 to something lower.

richardliaw commented 5 years ago

Yeah that makes sense.

On Sat, Aug 10, 2019 at 4:42 PM Anthony Yu notifications@github.com wrote:

@anthonyhsyu commented on this pull request.

In tune_exercises/exercise_1_basics.ipynb https://github.com/ray-project/tutorial/pull/135#discussion_r312718257:

@@ -200,8 +200,8 @@ "\n", "results = tune.run(\n", " tune_iris, \n",

  • " config={\"lr\": 0.1, \"dense_1\": 1, \"dense_2\": 0.1},\n",
  • " num_samples=1,\n",
  • " config={\"lr\": 0.1, \"dense_1\": 1, \"dense_2\": 2},\n",
  • " num_samples=10,\n",

Should we likewise change the assertion below to 2 as well?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ray-project/tutorial/pull/135?email_source=notifications&email_token=ABCRZZN2UNGT6XCC7NEBVVLQD5G5ZA5CNFSM4IK2SD3KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCBGGO7A#discussion_r312718257, or mute the thread https://github.com/notifications/unsubscribe-auth/ABCRZZKIIKS35RPZHBETUTTQD5G5ZANCNFSM4IK2SD3A .