ray-project / xgboost_ray

Distributed XGBoost on Ray
Apache License 2.0
143 stars 34 forks source link

Fail CI if tests do not pass #113

Closed Yard1 closed 3 years ago

Yard1 commented 3 years ago

This PR makes the CI scripts exit with correct status if at least one test fails. Previously, no matter what the test results were, the CI always passed (aside from linting). This may uncover some bad tests/errors that were not noticed before.

The run_ci_tests.sh script was made so that all tests will run instead of exiting CI as soon as a pytest invocation fails in order to simplify debugging. Same could be done for examples but I don't think it's worth it.