search

ray-project / xgboost_ray

Distributed XGBoost on Ray
Apache License 2.0
133 stars 34 forks source link

Adding to support to feature_weights #264

Closed mozjay0619 closed 1 year ago

mozjay0619 commented 1 year ago

The current xgboost_ray does not support feature_weights, which I need the support for.

I implemented the feature_weights support in my personal local branch, which I tested for both _CentralRayDMatrixLoader and _DistributedRayDMatrixLoader (did not add the support for RayDeviceQuantileDMatrix). Is there a way to put in the PR for this branch? I don't seem to have permission to do so.

Yard1 commented 1 year ago

You should be able to submit a PR - we have not restricted that.

mozjay0619 commented 1 year ago

You are right. I just submitted the PR (https://github.com/ray-project/xgboost_ray/pull/265) for the new support. Closing this issue.