search

ray-x / go.nvim

G'day Nvimer, Joyful Gopher: Discover the Feature-Rich Go Plugin for Neovim
MIT License
2.06k stars 123 forks source link

`run_in_floaterm` overrides test_runner is using go #336

Closed MadsRC closed 4 months ago

MadsRC commented 1 year ago

I recently tried setting run_in_floaterm and noticed that the next time I ran :GoTest, richgo test -v ... would be executed instead of the regular go test runner I have configured.

I then tried to reconfigure test_runner to use richgo instead, and that caused richgo test ... to be run when I ran :GoTest (notice the missing -v despite also having verbose_tests set to true (I know it's deprecated).

I had a look at the codebase, but couldn't immediately locate the culprit - Lua isn't my strong side.

This was replicated using the default config from the README.md file.

ray-x commented 1 year ago

Yes, richgo will overrides default test_runner if running in floating term... This is because it looks better in floating terminal. Do you want me adding -v to the richgo test ?

shaunduncan commented 5 months ago

I found this issue after experiencing the same behavior. Personally I would expect it to honor test_runner regardless of using run_in_floaterm or not, specifically because that is the output I prefer to see.

ray-x commented 4 months ago

I think the issue is obsolete, as richgo has been removed. other test_runner will not be override run_in_floaterm setting.