ray-x / lsp_signature.nvim

LSP signature hint as you type
Apache License 2.0
2.07k stars 57 forks source link

Update Causes `Unknown function: unique` alongside `tsserver` #152

Closed harrysolovay closed 2 years ago

harrysolovay commented 2 years ago

I just updated lsp_signature and am now running into issues in buffers to which I attach tsserver (no such problem with other language servers).

When I enter insert mode, I get the following error:

Error executing vim.schedule lua callback: Vim:E117: Unknown function: unique
stack traceback:
        [C]: in function 'unique'
        ...er/start/lsp_signature.nvim/lua/lsp_signature/helper.lua:513: in function 'chec
k_lsp_cap'
        ...cker/start/lsp_signature.nvim/lua/lsp_signature/init.lua:440: in function 'sign
ature'
        ...cker/start/lsp_signature.nvim/lua/lsp_signature/init.lua:556: in function 'cb'
        vim.lua:285: in function <vim.lua:285>

Any thoughts / suggestions would be greatly appreciated. Thank you!

cseickel commented 2 years ago

Me too.

:version
NVIM v0.7.0-dev+751-g67bb01ae2
jemag commented 2 years ago

I can confirm the problem. Seems to have been introduced in the last commit, since reverting to this commit resolves the problem for me:

    use({
      "ray-x/lsp_signature.nvim",
      config = function()
        require("plugin-configs.lsp_signature")
      end,
      commit = "be39dacc17d51531f9e3a50f88de0a45683c6634"
    })
cseickel commented 2 years ago

That commit works fine for me too.

ray-x commented 2 years ago

thanks for submitting the issue. Should be fixed.

harrysolovay commented 2 years ago

Confirmed, it's fixed! Thank you @ray-x! & might I say, AWESOME PLUGIN!