ray-x / lsp_signature.nvim

LSP signature hint as you type
Apache License 2.0
2.02k stars 58 forks source link

Last active parameters' highlighting not getting cleared #159

Closed mbenford closed 2 years ago

mbenford commented 2 years ago

When typing function arguments the last active parameters' highlight aren't getting cleared anymore:

image

I've tracked it down to commit 0b27fb039ab51681649b613d2825a54965f831ec. Up until 724d955915d64713fade35f98b96cf50a45e9f88 it was working correctly:

image

ray-x commented 2 years ago

Would you send a minium vimrc to reproduce this issue. I do not see the issue in my config.

mbenford commented 2 years ago

Sorry for not providing it in the first place. I thought the commits themselves would pinpoint the issue. Here you go:

vim.cmd('packadd packer.nvim')

return require('packer').startup(function(use)
  use 'wbthomason/packer.nvim'
  use 'neovim/nvim-lspconfig'
  use {'williamboman/nvim-lsp-installer',
    config = function()
      local installer = require('nvim-lsp-installer')
      installer.on_server_ready(function(server)
        server:setup({})
      end)
    end
  }
  use {'ray-x/lsp_signature.nvim',
    config = function()
      require('lsp_signature').setup({
        hint_enable = false,
      })
    end
  }
end)

And here is the result: image

I noticed that it only happens when hint_enable is false.

ray-x commented 2 years ago

thanks, should be fixed with latest version

mbenford commented 2 years ago

It's fixed now. Thanks for such a quick response!