search

ray-x / lsp_signature.nvim

LSP signature hint as you type
Apache License 2.0
1.98k stars 53 forks source link

regression on `toggle_float_win()` #314

Closed Zeioth closed 4 months ago

Zeioth commented 4 months ago

fed2c8389c148ff1dfdcdca63c2b48d08a50dea0 break the fix introduced in cc2909033296592106e3835fa46672a56afcbaf3.

require('lsp_signature').toggle_float_win()

Has stopped to work. It doesn't hide/unhide the help window on execution time anymore.

Zeioth commented 4 months ago

There is any chance we can keep my commit? I tested it extensively and it doesn't seem to break anything, but please let me know if you found something so I can ship the patch.

Zeioth commented 4 months ago

Jut for clarity, this is the case of use my commit cover: https://www.youtube.com/watch?v=-GmqPiHeKqk

Zeioth commented 4 months ago

Ok after diving into the code I see you've added a option to enable this behavior.

toggle_key_flip_floatwin_setting = true

Thank you so much for the consideration 🙏❤️