[feat]: multiple hint_prefix icons, based on hint's location

ray-x / lsp_signature.nvim

LSP signature hint as you type

Apache License 2.0

1.98k stars 53 forks source link

[feat]: multiple hint_prefix icons, based on hint's location #324

Closed spflaumer closed 1 month ago

spflaumer commented 1 month ago

This PR aims to add support for 3 separate icons to be used for the hint_prefix, based on where the hint is displayed:

'above' the current line
'current' line
'below' the current line

When a string is given as the option to 'hint_prefix', it's assumed to be the only icon used.

screenshots: above current below

ray-x commented 1 month ago

Thanks for the PR. It looks really nice. Could you address the lint warning: https://github.com/ray-x/lsp_signature.nvim/actions/runs/9195084892/job/25290062709?pr=324

Thanks!

spflaumer commented 1 month ago

Sure!

I forgot to lint, sorry!

spflaumer commented 1 month ago

I've resolved the first error on line 118, but i'm unsure what causes the second error on line 123, with the show_at variable. It is used later on; I've no idea why it complains

ray-x commented 1 month ago

No worries, leave the rest to me. Thanks for the PR.

spflaumer commented 1 month ago

Alright, thanks for your effort on this awesome plugin! I'm happy to contribute