rayantony / jixedbar

Automatically exported from code.google.com/p/jixedbar
GNU General Public License v2.0
0 stars 0 forks source link

Passing in options doesn't work - default options are still taken #45

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
I'm not a jquery expert by any means, but I've tried the following:

What steps will reproduce the problem?
1. Call jixedbar, passing in non-default options.
2. The default options get used instead.
3. Attempting to do "console.log(options)" from within the plugin function (to 
which the options are passed in) doesn't work - the options variable is 
undefined.

What version of the product are you using? On what operating system?
0.0.5

Original issue reported on code.google.com by edanm%bt...@gtempaccount.com on 17 Nov 2010 at 3:53

GoogleCodeExporter commented 9 years ago
I don't know anything about JQuery plugins.

But I tried a few things out in the code, and I fixed the bug (I think.)

The "options" variable shouldn't be passed in here: 
jixedbar: new function(options)

Rather, it should be passed in to the construct function 
(this.construct(options)).

Original comment by edanm%bt...@gtempaccount.com on 17 Nov 2010 at 4:06

GoogleCodeExporter commented 9 years ago
OK I just tried checking out the source code, apparently the latest version of 
the code works (and has been rearchitected, it doesn't have a "construct" 
function.)

Hope you can put a warning or something on the main page, so other people 
downloading the "stable" release don't have the same issue.

Original comment by edanm%bt...@gtempaccount.com on 17 Nov 2010 at 4:09

GoogleCodeExporter commented 9 years ago
thanks for the tip regarding using the latest repository version. :)

Original comment by blackout...@gmail.com on 26 Aug 2011 at 5:20