search

raycast / extensions

Everything you need to extend Raycast.
https://developers.raycast.com
MIT License
5.24k stars 2.94k forks source link

[GIF Search] Tenor gif search returns irrelevant results #11718

Closed amarckal closed 3 months ago

amarckal commented 5 months ago

Extension

https://www.raycast.com/josephschmitt/gif-search

Description

Searching for gifs in Tenor seems to be broken. For example searching for the classic "Point to Head" meme returns these results:

image

Entering the same text in the search bar returns different results every time as well

Doing the search on Tenor directly works without issues, see:

image

Steps To Reproduce

  1. Run the ray cast gif search and search for gifs in Tenor.
  2. Delete a single character or more and wait for it to trigger another search, after that enter back the original text and notice how the search results are now completely different

Current Behaviour

No response

Expected Behaviour

No response

raycastbot commented 5 months ago

Thank you for opening this issue!

🔔 @josephschmitt @tmwrnr @j3lte @samuelkraft you might want to have a look.

💡 Author and Contributors commands The author and contributors of `josephschmitt/gif-search` can trigger bot actions by commenting: - `@raycastbot close this issue` Closes the issue. - `@raycastbot rename this issue to "Awesome new title"` Renames the issue. - `@raycastbot reopen this issue` Reopen the issue.
j3lte commented 5 months ago

Unfortunately that's not an easy fix, this needs a bit of a rewrite of the Tenor API implementation in the extension. Currently it is using V1 of the API, while Tenor has gone to V2 (with a different API key, url and url parameters). This migration is documented here.

The original author (@josephschmitt) provides API keys for these services, but this is a key for V1. Meaning that in order to update the extension in the first place, we will need an extra key coming from https://cdn.joe.sh/gif-search/config.json (something like tenor_v2). Only then could we migrate the Tenor code of the extension to V2.

thomaslombart commented 5 months ago

I'll take a look at it.

raycastbot commented 3 months ago

This issue has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 10 days to keep our backlog clean 😊