search

raycast / extensions

Everything you need to extend Raycast.
https://developers.raycast.com
MIT License
5.02k stars 2.74k forks source link

[Upcoming Holidays] ...UK holidays incorrect #12649

Open DaveS79 opened 1 month ago

DaveS79 commented 1 month ago

Extension

https://www.raycast.com/rodrigouroz/upcoming-holidays

Description

Hi enjoying using this extension but not sure what is the source as it is missing summer bank holiday in the UK holidays list.

Who will benefit from this feature?

everyone using UK list

Anything else?

No response

raycastbot commented 1 month ago

Thank you for opening this issue!

🔔 @rodrigouroz you might want to have a look.

💡 Author and Contributors commands The author and contributors of `rodrigouroz/upcoming-holidays` can trigger bot actions by commenting: - `@raycastbot close this issue` Closes the issue. - `@raycastbot rename this issue to "Awesome new title"` Renames the issue. - `@raycastbot reopen this issue` Reopens the issue. - `@raycastbot assign me` Assigns yourself to the issue. - `@raycastbot good first issue` Adds the "Good first issue" label to the issue. - `@raycastbot keep this issue open` Make sure the issue won't go stale and will be kept open by the bot.
ramsaysewell commented 2 weeks ago

Hey,

I'm not a contributor to this extension but I've been able to dig down what the issue is.

Having had a quick look around, I can see that the raw data is coming from Calendarific. The Raycast extension requests data from this AskHolidays API using country codes. With the United Kingdom being listed as a "country", there's only a couple of "national" holidays that should technically be shown, as not all holidays occur on the same day for every country within the nation. For example, Scotland's Summer Bank Holiday commences on a different date to the other countries...

A solution to this would be to split the UK up into it's 4 countries to the following:

This solution would also require the API request to AskHolidays to use the holiday type of local instead of national.

I'd be hapy to do this work for the extension if it sounds like a good solution?

rodrigouroz commented 2 weeks ago

I'm sorry I couldn't get back to this before, I don't have time right now, but I'd be happy to review your PR and help you with this.