raycast / extensions

Everything you need to extend Raycast.
https://developers.raycast.com
MIT License
5.02k stars 2.75k forks source link

[Network Drive] Extension asks to install Samba, while macOS Samba is already installed #12905

Open j-peeters opened 3 weeks ago

j-peeters commented 3 weeks ago

Extension

https://www.raycast.com/SuoweiHu/network-drive

Raycast Version

1.76.0

macOS Version

14.5

Description

Thanks for developing this extension. AFAIK Apple is using Samba to mount network drives. So Samba is probably installed. The extensions doesn't recognize this and asks to install Samba via Homebrew. This feels superfluous and might cause conflicts by installing it again. Maybe there's a way to recognize the already installed Samba or just tap into it. Thanks

Steps To Reproduce

  1. install extension
  2. configure extension
  3. extension asks to install Samba

Current Behaviour

Extension asks to install Samba

Expected Behaviour

Extensions uses build in macOS Samba.

raycastbot commented 3 weeks ago

Thank you for opening this issue!

🔔 @SuoweiHu you might want to have a look.

💡 Author and Contributors commands The author and contributors of `SuoweiHu/network-drive` can trigger bot actions by commenting: - `@raycastbot close this issue` Closes the issue. - `@raycastbot rename this issue to "Awesome new title"` Renames the issue. - `@raycastbot reopen this issue` Reopens the issue. - `@raycastbot assign me` Assigns yourself to the issue. - `@raycastbot good first issue` Adds the "Good first issue" label to the issue. - `@raycastbot keep this issue open` Make sure the issue won't go stale and will be kept open by the bot.
SuoweiHu commented 3 weeks ago

Thank you for point this out @j-peeters, I'll have a look on this ASAP I can(・ω・)b

SuoweiHu commented 3 weeks ago

Hello @j-peeters,

I have spent some time investigating the suggested built-in samba, I cannot find anything except for the smbutil, it is produce similar output to what I am trying to do with smbclient (from samba installed via brew); But this smbutil has no control over the format of the output (json/table/csv/etc), which will make the cleaning of the output a bit challenging.

And I recon it is a old version of smbutil as well. As it have no logout sub-command which seems to appear on the man-page for smbutil https://man.freebsd.org/cgi/man.cgi?query=smbutil&format=html.

Hence, for all the reasons, I feel like there's some proper reasons for us to use the smbclient (from samba installed via brew) in this instance. Please let me know what you think on this matter :)

Kind Regards, Simon Hu

SuoweiHu commented 3 weeks ago

Humm after a second though I think you've got the point, system level utility should be the priority goto, I'll try cleanup stdout smbutil, hopefully I can replicate the same effect with it.

SuoweiHu commented 3 weeks ago

Hello @j-peeters, I have address your suggestion on pull-#12923. Appreciate your valuable comment !

j-peeters commented 3 weeks ago

Hello @j-peeters, I have address your suggestion on pull-#12923. Appreciate your valuable comment !

Thank you so much for your research and considerations, Simon. I will try it out once the pull is merged by Raycast team.