[Quick Event] Is this correct?

raycast / extensions

Everything you need to extend Raycast.

https://developers.raycast.com

MIT License

5.23k stars 2.92k forks source link

[Quick Event] Is this correct? #13260

Closed Martin-Gonzalez90 closed 1 month ago

Martin-Gonzalez90 commented 2 months ago

Extension

https://www.raycast.com/mblode/quick-event

Raycast Version

1.77.3

macOS Version

14.5

Description

I just realized that if I add PM to a 24hs system format it counts an extra day. Is not something important, but just wanted to report it.

Steps To Reproduce

Just opened the Create Quick Event from the calendar extension. Typed "Soemthing, August 30 at 16pm" If you remove PM it uses the correct date

Current Behaviour

No response

Expected Behaviour

No response

raycastbot commented 2 months ago

Thank you for opening this issue!

🔔 @mblode @bascomb you might want to have a look.

💡 Author and Contributors commands

The author and contributors of `mblode/quick-event` can trigger bot actions by commenting: - `@raycastbot close this issue` Closes the issue. - `@raycastbot rename this issue to "Awesome new title"` Renames the issue. - `@raycastbot reopen this issue` Reopens the issue. - `@raycastbot assign me` Assigns yourself to the issue. - `@raycastbot good first issue` Adds the "Good first issue" label to the issue. - `@raycastbot keep this issue open` Make sure the issue won't go stale and will be kept open by the bot.

MagnusHJensen commented 1 month ago

I guess it makes good sense, since you're mixing the two, and it tries it best by saying okay so at August 30th, 16 (4PM) and then adding PM, makes 16 normally, an invalid value, but it just sees it as that, and adds 4 hours on top of 12PM. Resulting in 4AM.

By the way, this is a limitation of the parser behind (SherlockJS), but this is what I would assume would happen.