[Bitwarden Vault] Generate password utility works incorrectly

[szarbartosz]

Extension

https://www.raycast.com/jomifepe/bitwarden

Raycast Version

1.80.0

macOS Version

14.5

Description

When trying to generate password using bitwarden extension, it adds the special characters to it, regardless of whether the option to include them is selected.

Steps To Reproduce

1. Open raycast and run Generate Password command from Bitwarden extension
2. Select type: Password
3. Enter the length of the desired password (eg. 20)
4. Make sure that the last checkbox (the one responsible for including special characters) is unchecked
5. Regenerate password multiple times and observe the outcome

Current Behaviour

Generated password contains special characters

Expected Behaviour

Generated password does not contain special characters

[raycastbot]

Thank you for opening this issue!

🔔 @jomifepe @daniel-stoneuk @andreaselia @pernielsentikaer @eth-p @YamenSharaf @undefinedzack @anirudhganwal06 @ivaarsson you might want to have a look.

💡 Author and Contributors commands

The author and contributors of `jomifepe/bitwarden` can trigger bot actions by commenting: - `@raycastbot close this issue` Closes the issue. - `@raycastbot rename this issue to "Awesome new title"` Renames the issue. - `@raycastbot reopen this issue` Reopens the issue. - `@raycastbot assign me` Assigns yourself to the issue. - `@raycastbot good first issue` Adds the "Good first issue" label to the issue. - `@raycastbot keep this issue open` Make sure the issue won't go stale and will be kept open by the bot.

[szarbartosz]

The same happens for the numeric characters:

[jomifepe]

Hey, yeah there seems to be an issue. I'm able to get consistent results with special characters, but I see that numerical are being included when unchecked. Will investigate.

@raycastbot assign me

[raycastbot]

This issue has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 10 days to keep our backlog clean 😊

[szarbartosz]

@jomifepe any update on this one? I checked it recently and the bug still occurs 🐞

[jomifepe]

@jomifepe any update on this one? I checked it recently and the bug still occurs 🐞

Hey, I'm planning to do some changes to the generate password command, which will include a fix for that, I just haven't found the time lately. Will probably open a PR for it soon. Sorry for the delay 🙂

[jomifepe]

Should be fixed, git it a try 🙂

[szarbartosz]

when tested locally I noticed that the password is still generated with special characters, even though the Special characters checkbox is not checked:

[jomifepe]

😔 Will investigate further. There might be some issue with the data already store locally, as the code seems to run fine for me, so it's hard to track the issue down.

[jomifepe]

@raycastbot reopen this issue