raycast / extensions

Everything you need to extend Raycast.
https://developers.raycast.com
MIT License
5.27k stars 2.97k forks source link

[Gitmoji Search] Use API instead of dependency #3301

Closed carloscuesta closed 1 year ago

carloscuesta commented 1 year ago

Extension – Gitmoji Search

Author

@ricoberger

Describe the feature and the current behavior/state

Hey! 👋🏼

Raycast user and fan here 😍

I saw there was a Gitmoji Search extension on Raycast Store, but recently saw the extension is using the gitmojis package published on the registry.

https://github.com/raycast/extensions/blob/70da3c740f2751eb560c599fb44cd33bf3c464c1/extensions/gitmoji/src/gitmoji.tsx#L2

The downside of this approach is that a new version of the extension needs to be published every time a new gitmoji is added. In the gitmoji website we have a simple API endpoint that provides all the emojis! 🎉

👉🏼 https://gitmoji.dev/api/gitmojis

Who will benefit from this feature?

Everyone!

stale[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊

ricoberger commented 1 year ago

HI @carloscuesta, I created a PR for this #3647, so that the extension tries to use the API and only falls back to the NPM package when the API call fails.

carloscuesta commented 1 year ago

Thank you for taking care of it! @ricoberger 🙏🏼