search

raycast / extensions

Everything you need to extend Raycast.
https://developers.raycast.com
MIT License
5.38k stars 3.08k forks source link

[GitHub] Add support for GitHub Enterprise #6410

Closed niksite closed 1 year ago

niksite commented 1 year ago

Extension

https://www.raycast.com/raycast/github

Description

Please add support for GitHub Enterprise.

This is essentially the same as GitHub, but with a custom GraphQL endpoint and the ability to use custom self-signed certificates.

Who will benefit from this feature?

All Raycast users employed by companies that use GitHub Enterprise instead of the common GitHub.

Anything else?

No response

raycastbot commented 1 year ago

Thank you for opening this issue!

🔔 @unnamedd @tonka3000 @khasbilegt @pernielsentikaer you might want to have a look.

💡 Tip: Once the issue is resolved, comment @raycastbot close this issue to close it.

thomaslombart commented 1 year ago

Thanks for the feature request. Would you like to work on it? I can provide you some guidance on how to contribute to this extension so that you can open a pull request.

In the meantime, you can also use this extension which seems to suit your needs: GitHub Enterprise

DanielVolchek commented 1 year ago

Hi, this is still open right? I'd like to take a crack at it if I can. It might take me some time but if no one else is working on it and it isn't a priority I could do it

thomaslombart commented 1 year ago

Hey @DanielVolchek, sure, feel free to tackle it 😊

yuha0 commented 1 year ago

This is essentially the same as GitHub, but with a custom GraphQL endpoint and the ability to use custom self-signed certificates.

fwiw, I can confirm that a simple sed 's/github.com/my-enterprise-instance-url/g' and it worked for me. However, besides trusting a self signed cert, one may also need to gracefully handle features that are not available in your installed version (e.g. I was trying to hit a legacy github enterprise instance on version 3.5, which does not have GitHub Discussion, and the extension crashed when it could not find hasDiscussionsEnabled in the API).

raycastbot commented 1 year ago

This issue has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 10 days to keep our backlog clean 😊

raycastbot commented 1 year ago

This issue has been automatically closed due to inactivity.

Feel free to comment in the thread when you're ready to continue working on it 🙂

You can also catch us in Slack if you want to discuss this.

joshgoebel commented 3 weeks ago

I can confirm that a simple sed 's/github.com/my-enterprise-instance-url/g' and it worked for me.

Wasn't quite that simple here... IIRC I had to change some token auth to bearer... and a few of the generated URLs (for notifications at least) didn't work... Our enterprise version adds an extra /api/v3/blah to the URL that needs to be stripped that the existing code isn't accounting for. And I was only testing notification stuff.

That said, I'm interested in at least getting the "happy paths" working here for people using modern Enterprise GitHub... if there are perhaps a few people who'd be happy to do some testing...?